search

Djarvur / go-err113

Golang linter to check the errors handling expressions
MIT License
45 stars 4 forks source link

Comparison with go-errorlint (https://github.com/polyfloyd/go-errorlint) #18

Open Antonboom opened 3 years ago

Antonboom commented 3 years ago

Hello!

At the moment, in golangci-lint, we have two linters that perform the same functionality.

Your linter appeared later, but it seems to have more options.

I would suggest: 1) Implement errors.As (https://github.com/Djarvur/go-err113/issues/14) 2) Make exceptions / flags for dynamic errors (https://github.com/Djarvur/go-err113/issues/10) 3) As a request from me: to require the creation of an error through the error.New if there are no formatting arguments:

var MyError  = fmt.Errorf("some error")

4) Support type switches.

And then that go-errorlint can be asked to archive :)

What do you think? If you do not mind the points above, I can try to find the time and help you implement them.

onokonem commented 3 years ago

Hi Anton,

all the 4 points looks reasonable (except 2 for me, but lets it go)

I'll be extremely busy myself for the next 4-6 weeks though :(

so any help would be highly appreciated!