Djaytan / mc-jobs-reborn-patch-place-break

A place-break patch extension of JobsReborn plugin for Bukkit servers (Minecraft).
MIT License
6 stars 2 forks source link

ci(release): plugin JAR file nor the tag version name could not be found #578

Closed Djaytan closed 9 months ago

Djaytan commented 9 months ago

The release v3.0.3 has been published successfully (https://github.com/Djaytan/mc-jobs-reborn-patch-place-break/releases/tag/v3.0.3)... But without the Spigot plugin nor the associated signature files! The PR for generating the changelog file failed to be created as well.

The observed errors:

[3:51:47 PM] [semantic-release] [@semantic-release/github] › ✘  The asset src/spigot-plugin/target/JobsReborn-PatchPlaceBreak-${nextRelease.version}.jar cannot be read, and will be ignored.

=> This means that the plugin path is wrong.

fatal: 'changelog/' is not a valid branch name

=> This means that the ${{ steps.release.outputs.tag }} context resolution in CHANGELOG_BRANCH_NAME: changelog/${{ steps.release.outputs.tag }} is resolved as an empty string, leading to a branch name being changelog/.

The fix for the first issue consist on adjusting the path in two ways:

The name and label for each assets are generated with Lodash template.

=> The path property isn't mentioned.

For the second issue, it seems clear that extracting the tag version name through environment variable isn't working. As a workaround, we just create a temporary file containing the value and then read it once the semantic-release CLI finishes its execution.

sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

github-actions[bot] commented 9 months ago

:tada: This PR is included in version 3.0.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 9 months ago

:tada: This PR is included in version 3.0.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: