test: avoid usage of Given/When/Then structure for trivial tests

Djaytan commented 7 months ago

The goal is to improve tests readability.

sonarcloud[bot] commented 7 months ago

Quality Gate passed

Djaytan commented 7 months ago

Finally, the change is aborted for the following reasons:

This change does not necessarily provide an improvement. The trade-off between shortening trivial tests or always sticking with a given template can be seen as 50/50.
A great argument from @jeanbaptisten suggests that always being consistent with the application of a pattern like here will implicitely encourages other developers to follow the same structure for the new tests. By relying on it only for a subset of tests, there is a risk of someone interpreting that as "there is not general rule to follow, I can do what I want"... Even if there could be a great reason of deviating from the general rule like here for improving readability.