Djaytan / mc-jobs-reborn-patch-place-break

A place-break patch extension of JobsReborn plugin for Bukkit servers (Minecraft).
MIT License
5 stars 2 forks source link

build(packaging): explicitly define the "test" scope for dependencies #596

Closed Djaytan closed 6 months ago

Djaytan commented 6 months ago

Providing an explicit scope to the dependencies defined in the dependencyManagement section doesn't affect the Maven execution. However, it becomes a lot easier for Renovate to identify the test dependencies. Retrieving accurate information regarding the dependency type allows him to infer the Conventional Commit type to apply:

=> https://docs.renovatebot.com/semantic-commits/

When taking a look to the Renovate's Dependency Dashboard of this repository (https://github.com/Djaytan/mc-jobs-reborn-patch-place-break/issues/6), we can see some mistakes:

Hence this change for solving these two observable issues.

Since it's not possible to infer whether an import Maven scope is for test or production, it has been decided to abort usages of this scope for the test dependencies (i.e. JUnit, Mockito and Testcontainers). That's not ideal, but it's acceptable for improving the release note accuracy and correctness.

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 3 weeks ago

:tada: This PR is included in version 3.0.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: