DjedAlliance / Djed-Solidity

Other
11 stars 5 forks source link

Differentiate rcMinPrice from rcInitialPrice #12

Closed ceilican closed 11 months ago

ceilican commented 1 year ago

In this file (https://github.com/DjedAlliance/Djed-Solidity/blob/main/src/Djed.sol), we can see that the contract takes an rcMinPrice as a parameter and uses it both as an initial price in line 213 and as a minimum price in line 214. We should modify the contract so that it takes two arguments (rcMinPrice and rcInitialPrice) and uses them accordingly.

We should also modify test files and deployment scripts, so that they are compatible with the new contract.

yogesh0509 commented 1 year ago

What should be the RESERVE_COIN_WHOLE_INITIAL_PRICE in the Utilities.sol.

ceilican commented 1 year ago

Let's make it 1e20.