search

Djenesis / contributr

An online tool for programmers to find projects they can contribute to and project maintainers to find contributors.
MIT License
16 stars 16 forks source link

conform to pep8 guidelines #76

Closed SanketDG closed 9 years ago

SanketDG commented 9 years ago

the pep8 tool https://github.com/PyCQA/pep8 was used to conform with pep8, the official code style guide for python.

https://www.python.org/dev/peps/pep-0008/

Note: People who contribute code should be also use the pep8 tool to check for pep8 issues.

This is the current output of pep8:

❯ pep8 .        
./contributr/manage.py:6:80: E501 line too long (80 > 79 characters)
./contributr/contributr/wsgi.py:14:80: E501 line too long (80 > 79 characters)
./contributr/contriblog/models.py:6:80: E501 line too long (81 > 79 characters)
./contributr/contriblog/migrations/0001_initial.py:18:80: E501 line too long (114 > 79 characters)

We can ignore the above errors for the sake of readability.

nitinpaultifr commented 9 years ago

Should we all follow pep8 guidelines for the sake of uniform coding conventions? Maybe add pep8 to requirements_dev.in?

ameistad commented 9 years ago

Yes I think it's a really good idea, with so many contributors the code can lose readability fast. We should think about writing something about it in the wiki.