search

Djphoenix719 / FVTT-PF2EToolbox

A collection of tweaks and improvements for both quality of life and system improvement for the Foundry VTT Pathfinder 2E system.
Apache License 2.0
16 stars 9 forks source link

Distribute Hero Point macro doesn't work #59

Closed tristerfalm closed 2 years ago

tristerfalm commented 2 years ago

Maybe from the new PF2E update, I don't know, but the macro to add Hero points doesn't do anything. I click it, type in 1, nothing's added. No console errors that I see, even with debug module. Possibly related to: if I right-click a dice roll result box and click "Reroll using a Hero Point" it will reroll but will also not subtract a Hero point.

tristerfalm commented 2 years ago

Ok, PF2E updated this morning and fixed the reroll Hero Point issue, but Toolbox needs to adjust "data.attributes.heroPoints.rank" to "data.resources.heroPoints.value". Seems the property names changed

Djphoenix719 commented 2 years ago

Yes I will correct this ASAP, I only have a few weeks of grad school left then I can do a full update of the module.

On Mon, Nov 22, 2021 at 10:19 AM tristerfalm @.***> wrote:

Ok, PF2E updated this morning and fixed the reroll Hero Point issue, but Toolbox needs to adjust "data.attributes.heroPoints.rank" to "data.resources.heroPoints.value". Seems the property names changed

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Djphoenix719/FVTT-PF2EToolbox/issues/59#issuecomment-975633500, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGX5JYOKN3GP5LMJRMQJWX3UNJNPFANCNFSM5IQC6V2A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.