search

Djphoenix719 / PDFoundry

A fully featured PDF viewer module for Foundry VTT, including form fillable actor sheets, journal links, and more!
Apache License 2.0
41 stars 20 forks source link

No PDF icon to click on Journal Entry in Foundry v9.236 #112

Closed lupestro closed 2 years ago

lupestro commented 2 years ago

Describe the bug PDF Icon doesn't appear when creating a PDF Journal Entry in Foundry v9

To Reproduce Steps to reproduce the behavior:

  1. Click on Journal Entries
  2. Click on Create PDF
  3. Select a PDF and fill in the form, check for page 5 and adjust offset, etc. Click
  4. Journal Entry is created without a PDF Icon to click, clicking text shows empty ordinary Journal Entry

Expected behavior A clickable PDF icon appears, which launches the PDF.

Version Information:

Additional context First encountered in a GURPS world, seen in a couple of others, then isolated for bug reporting in Simple.

Djphoenix719 commented 2 years ago

Thanks for the report, I'll check it out ASAP.

On Mon, Dec 20, 2021, 14:50 Ralph Mack @.***> wrote:

Describe the bug PDF Icon doesn't appear when creating a PDF Journal Entry in Foundry v9

To Reproduce Steps to reproduce the behavior:

  1. Click on Journal Entries
  2. Click on Create PDF
  3. Select a PDF and fill in the form, check for page 5 and adjust offset, etc. Click
  4. Journal Entry is created without a PDF Icon to click, clicking text shows empty ordinary Journal Entry

Expected behavior A clickable PDF icon appears, which launches the PDF.

Version Information:

  • Browser: Chrome 96
  • FoundryVTT 9.236
  • PDFoundry 0.8.10
  • System: Simple World-Building 0.6.1
  • Modules: No other modules

Additional context First encountered in a GURPS world, seen in a couple of others, then isolated for bug reporting in Simple.

— Reply to this email directly, view it on GitHub https://github.com/Djphoenix719/PDFoundry/issues/112, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGX5JYKVBPIGUI7Y66O4AP3UR6CINANCNFSM5KOPSWXA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

sanpats commented 2 years ago

I encountered the same bug in 9.238. All PDF entries were shown as ordinary Journal Entries. If you click it it will show the ordinary Journal window,not PDF setting window. Of cource no PDF icon on the right to open the PDF. However, link to PDF from other journals still work.

Djphoenix719 commented 2 years ago

Yes it seems to be an issue related to the Foundry update. Thanks for the confirmation.

On Tue, Dec 21, 2021, 02:06 sanpats @.***> wrote:

I encountered the same bug. All PDF entries were shown as ordinary Journal Entries. If you click it it will show the ordinary Journal window,not PDF setting window. Of cource no PDF icon on the right to open the PDF. However, link to PDF from other journals still work.

— Reply to this email directly, view it on GitHub https://github.com/Djphoenix719/PDFoundry/issues/112#issuecomment-998525870, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGX5JYPMT5YIUXHUN5TP6E3USARQJANCNFSM5KOPSWXA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

sanpats commented 2 years ago

New version of PDFoundry 0.9.0 shown as PDFoundry 0.8.9 in Foundry and doesn't fix the bug.

Djphoenix719 commented 2 years ago

Yes I am not done uploading it, so that is still the old version.

Djphoenix719 commented 2 years ago

It should now update properly.

sanpats commented 2 years ago

Work great now, but in module.json should be "minimumCoreVersion": "9", "compatibleCoreVersion": "9", ,not 0.9. They change the version numbering. 0.9 show as compatibility risk. image

Djphoenix719 commented 2 years ago

Yes thanks. I saw that but am not going to push a build just for that. Next update will include it.

On Tue, Dec 21, 2021, 18:00 sanpats @.***> wrote:

Work great now, but in module.json should be "minimumCoreVersion": "9", "compatibleCoreVersion": "9", ,not 0.9. They change the version numbering. 0.9 show as compatibility risk. [image: image] https://user-images.githubusercontent.com/22677493/147008545-5476a2a4-f3e6-4cfc-9ecc-a940e82c944e.png

— Reply to this email directly, view it on GitHub https://github.com/Djphoenix719/PDFoundry/issues/112#issuecomment-999150462, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGX5JYI33W6VUJUNB2OWNL3USEBJNANCNFSM5KOPSWXA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you modified the open/close state.Message ID: @.***>