Increase feature generation speed in features.py

Dlux804 / McQuade-Chem-ML

Development of easy to use and reproducible ML scripts for chemistry.

5 stars 1 forks source link

Increase feature generation speed in features.py #21

Closed qle2 closed 4 years ago

qle2 commented 4 years ago

Is your feature request related to a problem? Please describe. The original piece of code is not a problem. Just a more efficient way to store things in a list.

Describe alternatives you've considered

Dlux804 commented 4 years ago

@qle2 I am a bit confused. Is this an issue? It seems like you have a solution ready to go. Just add it to your #22 and commit/push. (Don't forget to edit your pull request to mention this issue). It can go into effect through that once the review is finished.

qle2 commented 4 years ago

Closes #22 .