Closed qle2 closed 4 years ago
Hello @qle2! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
core/analysis.py
:Line 33:80: E501 line too long (80 > 79 characters) Line 35:80: E501 line too long (113 > 79 characters) Line 36:80: E501 line too long (120 > 79 characters) Line 45:80: E501 line too long (85 > 79 characters) Line 46:32: E127 continuation line over-indented for visual indent Line 49:80: E501 line too long (87 > 79 characters) Line 51:80: E501 line too long (91 > 79 characters) Line 77:29: E703 statement ends with a semicolon Line 78:27: E703 statement ends with a semicolon Line 90:80: E501 line too long (94 > 79 characters) Line 92:80: E501 line too long (119 > 79 characters) Line 97:80: E501 line too long (112 > 79 characters) Line 144:80: E501 line too long (83 > 79 characters)
core/grid.py
:Line 41:80: E501 line too long (117 > 79 characters) Line 42:80: E501 line too long (117 > 79 characters) Line 43:80: E501 line too long (117 > 79 characters) Line 44:80: E501 line too long (117 > 79 characters) Line 45:80: E501 line too long (119 > 79 characters)
core/models.py
:Line 78:80: E501 line too long (139 > 79 characters) Line 82:80: E501 line too long (128 > 79 characters) Line 83:80: E501 line too long (141 > 79 characters)
@Dlux804 Please review once more.
This Closes #1
Hey @Dlux804 I have combined the two functions called multipredict and replicate_model in analysis into one function so we don't have to run them 10 times. I also added a function that makes importance graph.
Please let me know what you think of them. Once you approve, I will make unittest for them.