Closed qle2 closed 4 years ago
Hello @qle2! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
core/models.py
:Line 89:80: E501 line too long (86 > 79 characters) Line 129:56: E225 missing whitespace around operator
core/name.py
:Line 6:80: E501 line too long (89 > 79 characters) Line 7:80: E501 line too long (105 > 79 characters) Line 10:1: E302 expected 2 blank lines, found 1 Line 13:80: E501 line too long (119 > 79 characters) Line 16:80: E501 line too long (95 > 79 characters) Line 21:80: E501 line too long (97 > 79 characters) Line 24:80: E501 line too long (95 > 79 characters) Line 26:80: E501 line too long (81 > 79 characters) Line 28:80: E501 line too long (81 > 79 characters) Line 39:80: E501 line too long (91 > 79 characters) Line 40:80: E501 line too long (97 > 79 characters) Line 44:80: E501 line too long (106 > 79 characters) Line 45:80: E501 line too long (89 > 79 characters) Line 46:80: E501 line too long (92 > 79 characters) Line 47:80: E501 line too long (118 > 79 characters) Line 48:80: E501 line too long (111 > 79 characters) Line 49:80: E501 line too long (111 > 79 characters) Line 52:80: E501 line too long (120 > 79 characters) Line 53:80: E501 line too long (110 > 79 characters) Line 55:80: E501 line too long (115 > 79 characters) Line 64:80: E501 line too long (119 > 79 characters) Line 67:80: E501 line too long (97 > 79 characters) Line 68:80: E501 line too long (114 > 79 characters) Line 70:80: E501 line too long (99 > 79 characters) Line 71:80: E501 line too long (92 > 79 characters) Line 84:80: E501 line too long (105 > 79 characters) Line 85:80: E501 line too long (99 > 79 characters) Line 86:80: E501 line too long (81 > 79 characters) Line 87:80: E501 line too long (85 > 79 characters) Line 89:80: E501 line too long (113 > 79 characters) Line 95:80: E501 line too long (117 > 79 characters) Line 96:80: E501 line too long (95 > 79 characters) Line 99:80: E501 line too long (101 > 79 characters) Line 100:80: E501 line too long (90 > 79 characters) Line 108:80: E501 line too long (109 > 79 characters)
main.py
:Line 22:80: E501 line too long (87 > 79 characters)
@Dlux804 I also noticed 2 things:
The move command you created in models.py (the final 4 lines in the function store()) does not work for me. According to one stackoverflow answer - since I am using a Windows machine - the code does not recognize it (https://stackoverflow.com/questions/52136609/mv-is-not-recognized-as-an-internal-or-external-command-operable-program-or-b). Does it work on your Windows machine?
I looked into why circleci has been failing constantly and it looks like descriptastorus is importing a pandas-like package that our mlapp does not contain. I will add it to our mlapp if you give the approval.
naming was created to give our current machine learning workflow a new naming scheme. This action includes a new file called name.py and models.py was also adjusted to use name.py's naming algorithm
Besides that, I adjusted regressor.py since it was using an old method to import gdb which will be deprecated in newer version of sklearn. I also adjusted main.py for easier testing and fix the variable importance function that was creating an error in models.py