Closed qle2 closed 4 years ago
Hello @qle2! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
core/analysis.py
:Line 156:26: E261 at least two spaces before inline comment
core/features.py
:Line 124:1: W391 blank line at end of file
core/grid.py
:Line 56:79: E261 at least two spaces before inline comment Line 56:80: E262 inline comment should start with '# ' Line 56:80: E501 line too long (95 > 79 characters) Line 58:61: E261 at least two spaces before inline comment Line 58:80: E501 line too long (95 > 79 characters) Line 59:80: E501 line too long (94 > 79 characters) Line 60:80: E501 line too long (97 > 79 characters)
core/models.py
:Line 25:80: E501 line too long (88 > 79 characters) Line 40:80: E501 line too long (111 > 79 characters) Line 43:80: E501 line too long (160 > 79 characters) Line 67:80: E501 line too long (96 > 79 characters) Line 68:74: E127 continuation line over-indented for visual indent Line 68:80: E501 line too long (112 > 79 characters) Line 69:74: E127 continuation line over-indented for visual indent Line 69:80: E501 line too long (99 > 79 characters) Line 72:80: E501 line too long (115 > 79 characters) Line 110:80: E501 line too long (102 > 79 characters) Line 125:40: W605 invalid escape sequence '\o' Line 134:80: E501 line too long (81 > 79 characters) Line 136:80: E501 line too long (91 > 79 characters) Line 145:80: E501 line too long (107 > 79 characters) Line 146:80: E501 line too long (99 > 79 characters) Line 149:80: E501 line too long (101 > 79 characters) Line 150:71: E261 at least two spaces before inline comment Line 150:80: E501 line too long (92 > 79 characters) Line 151:80: E501 line too long (89 > 79 characters) Line 158:80: E501 line too long (90 > 79 characters)
core/regressors.py
:Line 55:1: E303 too many blank lines (4) Line 55:80: E501 line too long (131 > 79 characters) Line 55:97: E251 unexpected spaces around keyword / parameter equals Line 55:99: E251 unexpected spaces around keyword / parameter equals Line 55:104: E261 at least two spaces before inline comment Line 90:80: E501 line too long (103 > 79 characters) Line 94:80: E501 line too long (116 > 79 characters) Line 94:117: W291 trailing whitespace Line 95:80: E501 line too long (117 > 79 characters) Line 95:118: W291 trailing whitespace Line 96:80: E501 line too long (117 > 79 characters) Line 96:118: W291 trailing whitespace Line 104:80: E501 line too long (80 > 79 characters)
main.py
:Line 25:80: E501 line too long (93 > 79 characters) Line 42:41: E261 at least two spaces before inline comment Line 42:80: E501 line too long (81 > 79 characters)
tests/test_regressors.py
:Line 58:1: E303 too many blank lines (3) Line 60:80: E501 line too long (107 > 79 characters) Line 65:80: E501 line too long (100 > 79 characters) Line 66:80: E501 line too long (97 > 79 characters)
My final commits and changes are on May 29, 2020.
In this commit, I:
Resolve Issue #37 by storing random seed in self in
models.py
Finalized my naming scheme from Issue #30 located in
name.py
and adapt it toregressor.py
andmodels.py
Add checkpoint and DeltaYStopper callbacks to
regressor.py
to resolve Issue #32Made some variable changes to
main.py
to for testing purposes.Add pandas_flavor to
mlapp.yml
to resolve a closed issueAdd SVR to list of models that need data normalization in
features.py
andmain.py
Temporarily made
test_regressor.py
andtest_models.py
less regid since I made some changes toregressor.py
andmodels.py
. I think we should keep it that way since @Dlux804 will also rework them in the early future.