Dlux804 / McQuade-Chem-ML

Development of easy to use and reproducible ML scripts for chemistry.
5 stars 1 forks source link

Development andres #57

Closed andreshyer closed 4 years ago

pep8speaks commented 4 years ago

Hello @andreshyer! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 28:80: E501 line too long (106 > 79 characters) Line 64:80: E501 line too long (97 > 79 characters) Line 76:80: E501 line too long (97 > 79 characters) Line 143:80: E501 line too long (83 > 79 characters) Line 145:80: E501 line too long (93 > 79 characters) Line 149:80: E501 line too long (83 > 79 characters)

Line 102:80: E501 line too long (96 > 79 characters) Line 103:80: E501 line too long (92 > 79 characters) Line 108:80: E501 line too long (95 > 79 characters) Line 112:80: E501 line too long (102 > 79 characters) Line 113:26: E128 continuation line under-indented for visual indent Line 122:80: E501 line too long (98 > 79 characters) Line 130:80: E501 line too long (110 > 79 characters)

Line 13:80: E501 line too long (80 > 79 characters) Line 23:80: E501 line too long (113 > 79 characters) Line 24:80: E501 line too long (89 > 79 characters) Line 34:80: E501 line too long (98 > 79 characters) Line 36:80: E501 line too long (114 > 79 characters) Line 44:80: E501 line too long (123 > 79 characters) Line 45:80: E501 line too long (94 > 79 characters) Line 51:80: E501 line too long (121 > 79 characters) Line 65:80: E501 line too long (118 > 79 characters) Line 67:80: E501 line too long (122 > 79 characters) Line 94:80: E501 line too long (116 > 79 characters) Line 95:80: E501 line too long (81 > 79 characters) Line 100:80: E501 line too long (113 > 79 characters) Line 115:80: E501 line too long (114 > 79 characters) Line 117:80: E501 line too long (122 > 79 characters) Line 118:80: E501 line too long (121 > 79 characters) Line 119:80: E501 line too long (89 > 79 characters) Line 124:80: E501 line too long (113 > 79 characters) Line 133:80: E501 line too long (113 > 79 characters) Line 135:80: E501 line too long (122 > 79 characters) Line 136:80: E501 line too long (121 > 79 characters) Line 137:80: E501 line too long (89 > 79 characters) Line 142:80: E501 line too long (121 > 79 characters)

Line 10:80: E501 line too long (80 > 79 characters) Line 17:80: E501 line too long (102 > 79 characters) Line 23:80: E501 line too long (111 > 79 characters) Line 27:80: E501 line too long (122 > 79 characters) Line 38:80: E501 line too long (106 > 79 characters) Line 47:80: E501 line too long (122 > 79 characters) Line 58:80: E501 line too long (82 > 79 characters) Line 60:80: E501 line too long (82 > 79 characters) Line 66:80: E501 line too long (92 > 79 characters) Line 76:80: E501 line too long (108 > 79 characters) Line 80:80: E501 line too long (116 > 79 characters) Line 82:80: E501 line too long (86 > 79 characters) Line 84:80: E501 line too long (86 > 79 characters) Line 86:80: E501 line too long (89 > 79 characters) Line 88:80: E501 line too long (86 > 79 characters) Line 90:80: E501 line too long (86 > 79 characters) Line 94:80: E501 line too long (99 > 79 characters) Line 107:80: E501 line too long (114 > 79 characters) Line 109:80: E501 line too long (86 > 79 characters) Line 111:80: E501 line too long (83 > 79 characters) Line 113:44: W292 no newline at end of file Line 113:44: W292 no newline at end of file Line 113:44: W292 no newline at end of file

Line 9:80: E501 line too long (80 > 79 characters) Line 21:80: E501 line too long (122 > 79 characters) Line 22:80: E501 line too long (120 > 79 characters) Line 30:80: E501 line too long (117 > 79 characters) Line 37:80: E501 line too long (84 > 79 characters) Line 45:80: E501 line too long (117 > 79 characters) Line 46:80: E501 line too long (95 > 79 characters) Line 47:80: E501 line too long (97 > 79 characters) Line 51:80: E501 line too long (83 > 79 characters) Line 59:80: E501 line too long (155 > 79 characters) Line 60:80: E501 line too long (95 > 79 characters) Line 61:80: E501 line too long (97 > 79 characters)

Line 7:80: E501 line too long (80 > 79 characters) Line 18:80: E501 line too long (117 > 79 characters) Line 20:80: E501 line too long (116 > 79 characters)

Line 10:80: E501 line too long (80 > 79 characters) Line 23:80: E501 line too long (113 > 79 characters) Line 24:80: E501 line too long (89 > 79 characters) Line 34:80: E501 line too long (98 > 79 characters) Line 36:80: E501 line too long (114 > 79 characters) Line 43:80: E501 line too long (106 > 79 characters) Line 44:80: E501 line too long (121 > 79 characters) Line 50:80: E501 line too long (83 > 79 characters) Line 51:80: E501 line too long (99 > 79 characters) Line 60:80: E501 line too long (109 > 79 characters) Line 65:80: E501 line too long (102 > 79 characters) Line 66:80: E501 line too long (99 > 79 characters)

Comment last updated at 2020-06-17 21:13:56 UTC
Dlux804 commented 4 years ago

In the future, @andreshyer please provide a detailed description of what is being updated within the pull request. @qle2 @dickeygh It is also up to you, as reviewers to ensure that the pull request and contained code is documented and of high quality.

Dlux804 commented 4 years ago

@andreshyer please retroactively add a description to this so we have the info. I am going through the recent activity to see what has been updated and this PR is labeled.