pep8speaks
commented
4 years ago Hello @andreshyer! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
- In the file
core/features.py:
Line 113:80: E501 line too long (100 > 79 characters) Line 114:80: E501 line too long (107 > 79 characters) Line 115:80: E501 line too long (106 > 79 characters) Line 116:80: E501 line too long (116 > 79 characters) Line 117:80: E501 line too long (118 > 79 characters) Line 119:80: E501 line too long (102 > 79 characters) Line 120:80: E501 line too long (104 > 79 characters) Line 121:80: E501 line too long (106 > 79 characters) Line 122:80: E501 line too long (116 > 79 characters) Line 123:80: E501 line too long (118 > 79 characters) Line 136:80: E501 line too long (102 > 79 characters) Line 137:80: E501 line too long (108 > 79 characters) Line 138:80: E501 line too long (106 > 79 characters) Line 139:80: E501 line too long (100 > 79 characters) Line 140:80: E501 line too long (118 > 79 characters) Line 142:80: E501 line too long (106 > 79 characters) Line 143:80: E501 line too long (109 > 79 characters) Line 144:80: E501 line too long (106 > 79 characters) Line 145:80: E501 line too long (100 > 79 characters) Line 146:80: E501 line too long (118 > 79 characters) Line 162:80: E501 line too long (125 > 79 characters)
- In the file
core/models.py:
Line 35:80: E501 line too long (119 > 79 characters) Line 36:80: E501 line too long (113 > 79 characters)
- In the file
core/storage.py:
Line 79:80: E501 line too long (86 > 79 characters)
- In the file
main.py:
Line 115:80: E501 line too long (104 > 79 characters) Line 116:33: E127 continuation line over-indented for visual indent
Minor changes:
Added smiles corralated with test, training, and validations set
When predictions.json is exported, the test smiles are exported as well
Added comments to files outlines changes made
Bug Fixes
Enhancements
Past changes
Added functions to pickle and unpickle model objects
Fixed export_json() to output grid