Closed qle2 closed 4 years ago
Hello @qle2! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
core/models.py
:Line 17:80: E501 line too long (113 > 79 characters) Line 22:80: E501 line too long (114 > 79 characters) Line 50:80: E501 line too long (86 > 79 characters) Line 117:80: E501 line too long (83 > 79 characters)
core/neo4j/fragments.py
:Line 64:80: E501 line too long (103 > 79 characters)
core/neo4j/nodes_to_neo4j.py
:Line 165:80: E501 line too long (95 > 79 characters)
core/neo4j/output_to_neo4j.py
:Line 91:80: E501 line too long (86 > 79 characters)
main.py
:Line 139:80: E501 line too long (114 > 79 characters)
new_tests/model_fixture.py
:Line 2:80: E501 line too long (119 > 79 characters) Line 3:80: E501 line too long (120 > 79 characters) Line 15:80: E501 line too long (118 > 79 characters) Line 16:80: E501 line too long (99 > 79 characters) Line 33:80: E501 line too long (115 > 79 characters) Line 36:80: E501 line too long (111 > 79 characters) Line 49:80: E501 line too long (118 > 79 characters) Line 53:80: E501 line too long (102 > 79 characters) Line 59:80: E501 line too long (80 > 79 characters) Line 78:1: E266 too many leading '#' for block comment Line 80:80: E501 line too long (118 > 79 characters) Line 88:36: W292 no newline at end of file Line 88:36: W292 no newline at end of file Line 88:36: W292 no newline at end of file
new_tests/test_analysis.py
:Line 6:10: E401 multiple imports on one line Line 7:80: E501 line too long (88 > 79 characters) Line 13:80: E501 line too long (119 > 79 characters) Line 15:80: E501 line too long (113 > 79 characters) Line 22:80: E501 line too long (87 > 79 characters) Line 23:80: E501 line too long (107 > 79 characters) Line 27:80: E501 line too long (116 > 79 characters) Line 28:80: E501 line too long (93 > 79 characters) Line 31:80: E501 line too long (91 > 79 characters) Line 34:1: W391 blank line at end of file
new_tests/test_features.py
:Line 9:80: E501 line too long (100 > 79 characters) Line 12:80: E501 line too long (84 > 79 characters) Line 16:80: E501 line too long (94 > 79 characters) Line 20:80: E501 line too long (90 > 79 characters) Line 22:80: E501 line too long (102 > 79 characters) Line 23:80: E501 line too long (93 > 79 characters) Line 24:80: E501 line too long (100 > 79 characters) Line 27:80: E501 line too long (87 > 79 characters) Line 32:80: E501 line too long (113 > 79 characters) Line 34:80: E501 line too long (115 > 79 characters) Line 37:80: E501 line too long (87 > 79 characters) Line 42:80: E501 line too long (113 > 79 characters) Line 44:80: E501 line too long (119 > 79 characters)
new_tests/test_ingest.py
:Line 15:80: E501 line too long (111 > 79 characters) Line 16:80: E501 line too long (109 > 79 characters) Line 23:80: E501 line too long (109 > 79 characters) Line 24:80: E501 line too long (110 > 79 characters) Line 26:80: E501 line too long (84 > 79 characters) Line 28:80: E501 line too long (88 > 79 characters)
new_tests/test_keras.py
:Line 2:80: E501 line too long (94 > 79 characters) Line 9:80: E501 line too long (114 > 79 characters) Line 13:80: E501 line too long (112 > 79 characters) Line 14:80: E501 line too long (91 > 79 characters) Line 23:80: E501 line too long (113 > 79 characters) Line 27:80: E501 line too long (113 > 79 characters) Line 28:80: E501 line too long (91 > 79 characters) Line 34:34: W292 no newline at end of file
new_tests/test_misc.py
:Line 2:10: E401 multiple imports on one line Line 11:1: E402 module level import not at top of file Line 12:1: E402 module level import not at top of file Line 19:80: E501 line too long (118 > 79 characters) Line 20:80: E501 line too long (119 > 79 characters) Line 22:80: E501 line too long (118 > 79 characters) Line 31:80: E501 line too long (82 > 79 characters) Line 34:43: W292 no newline at end of file
new_tests/test_regressors.py
:Line 17:80: E501 line too long (109 > 79 characters) Line 25:80: E501 line too long (92 > 79 characters) Line 31:80: E501 line too long (116 > 79 characters) Line 32:80: E501 line too long (116 > 79 characters) Line 33:80: E501 line too long (116 > 79 characters) Line 35:80: E501 line too long (115 > 79 characters) Line 43:80: E501 line too long (87 > 79 characters) Line 44:80: E501 line too long (86 > 79 characters) Line 48:1: W391 blank line at end of file
new_tests/test_storage.py
:Line 14:80: E501 line too long (113 > 79 characters) Line 20:80: E501 line too long (113 > 79 characters) Line 22:61: E127 continuation line over-indented for visual indent Line 22:80: E501 line too long (112 > 79 characters) Line 28:80: E501 line too long (84 > 79 characters) Line 33:80: E501 line too long (86 > 79 characters) Line 34:50: W292 no newline at end of file
new_tests/test_train.py
:Line 5:80: E501 line too long (88 > 79 characters) Line 10:80: E501 line too long (84 > 79 characters) Line 13:80: E501 line too long (119 > 79 characters) Line 22:80: E501 line too long (116 > 79 characters) Line 24:36: W292 no newline at end of file Line 24:36: W292 no newline at end of file Line 24:36: W292 no newline at end of file
tests/model_fixture.py
:Line 2:80: E501 line too long (119 > 79 characters) Line 3:80: E501 line too long (120 > 79 characters) Line 15:80: E501 line too long (118 > 79 characters) Line 16:80: E501 line too long (99 > 79 characters) Line 23:80: E501 line too long (86 > 79 characters) Line 24:80: E501 line too long (115 > 79 characters) Line 30:80: E501 line too long (114 > 79 characters) Line 32:80: E501 line too long (93 > 79 characters) Line 36:80: E501 line too long (115 > 79 characters) Line 39:80: E501 line too long (111 > 79 characters) Line 48:80: E501 line too long (89 > 79 characters) Line 49:80: E501 line too long (120 > 79 characters) Line 50:80: E501 line too long (113 > 79 characters) Line 56:80: E501 line too long (114 > 79 characters) Line 58:80: E501 line too long (80 > 79 characters) Line 62:80: E501 line too long (115 > 79 characters) Line 65:80: E501 line too long (111 > 79 characters) Line 87:80: E501 line too long (115 > 79 characters) Line 90:80: E501 line too long (111 > 79 characters) Line 114:1: E266 too many leading '#' for block comment Line 116:80: E501 line too long (118 > 79 characters) Line 124:36: W292 no newline at end of file Line 124:36: W292 no newline at end of file Line 124:36: W292 no newline at end of file
tests/test_analysis.py
:Line 6:10: E401 multiple imports on one line Line 13:80: E501 line too long (112 > 79 characters) Line 21:80: E501 line too long (114 > 79 characters) Line 22:80: E501 line too long (91 > 79 characters) Line 25:80: E501 line too long (89 > 79 characters) Line 28:1: W391 blank line at end of file
tests/test_features.py
:Line 10:80: E501 line too long (100 > 79 characters) Line 13:80: E501 line too long (114 > 79 characters) Line 17:80: E501 line too long (90 > 79 characters) Line 19:80: E501 line too long (102 > 79 characters) Line 20:80: E501 line too long (93 > 79 characters) Line 21:80: E501 line too long (100 > 79 characters) Line 24:80: E501 line too long (114 > 79 characters) Line 30:80: E501 line too long (113 > 79 characters) Line 32:80: E501 line too long (115 > 79 characters) Line 35:80: E501 line too long (114 > 79 characters) Line 41:80: E501 line too long (113 > 79 characters) Line 43:80: E501 line too long (119 > 79 characters)
tests/test_grid.py
:Line 6:32: E271 multiple spaces after keyword Line 12:80: E501 line too long (96 > 79 characters)
tests/test_ingest.py
:Line 5:32: E271 multiple spaces after keyword Line 10:80: E501 line too long (114 > 79 characters)
tests/test_keras.py
:Line 2:80: E501 line too long (94 > 79 characters) Line 9:80: E501 line too long (120 > 79 characters) Line 10:80: E501 line too long (84 > 79 characters) Line 17:80: E501 line too long (119 > 79 characters) Line 18:80: E501 line too long (84 > 79 characters)
tests/test_regressors.py
:Line 14:80: E501 line too long (114 > 79 characters) Line 27:80: E501 line too long (97 > 79 characters) Line 39:80: E501 line too long (96 > 79 characters) Line 49:80: E501 line too long (113 > 79 characters) Line 56:80: E501 line too long (84 > 79 characters)
tests/test_sklearn.py
:Line 2:80: E501 line too long (96 > 79 characters) Line 5:10: E401 multiple imports on one line Line 7:80: E501 line too long (83 > 79 characters) Line 12:80: E501 line too long (111 > 79 characters) Line 20:80: E501 line too long (110 > 79 characters) Line 29:80: E501 line too long (91 > 79 characters) Line 31:80: E501 line too long (82 > 79 characters) Line 36:1: W391 blank line at end of file
tests/test_storage.py
:Line 15:80: E501 line too long (114 > 79 characters) Line 25:80: E501 line too long (114 > 79 characters) Line 46:80: E501 line too long (114 > 79 characters) Line 52:50: W292 no newline at end of file
tests/test_train.py
:Line 5:80: E501 line too long (86 > 79 characters) Line 16:80: E501 line too long (95 > 79 characters) Line 26:34: W292 no newline at end of file
This PR was created to address Issues #74. In it, I:
Mainly revamped our unit tests in the
tests
.Redid the config.yml so that the key CircleCI generates in every test is contained in each branch. This is to contain CircleCI errors from going to other branches.
Removed rdkit2d-SMILES relationships and reduce the number of fragments we're generating for our Neo4j graphs.
I will be adding documentations to each testing functions soon