"To" and "Subject" fields for Google Inbox mail (not Gmail) are wonky

[jaybosamiya]

With both the extension enabled as well as the extension disabled, the To and Subject fields look wonky:

Steps to reproduce:

• Use a dark background theme (I'm using Arc-Dark)
  • PS: I also have Arc-Dark as my Firefox theme
• Go to https://inbox.google.com/ and try to compose a mail (got from bottom right corner).
• Enable/Disable extension : nothing changes.

Please do let me know if I can provide any other useful information, or what I might be able to do to fix this. Thanks a lot :) Also, I love that this project has basically fixed almost every other problem I had on most websites. It's only this minor annoyance now (it is not unreadable, but just is wrong; no such issue on Gmail's compose window).

[DmitriK]

tl:dr; The force-standard colors feature should be able fix this (via menu, and via the override lists to make it persist)

It looks like both of those inputs do not have any fore- or background colors defined by google's CSS, so it's using the native (Arc-Dark in this case) input styling. Because readability is good, the extensions treats it as OK and does nothing. This is by design, as I made this extension with the express desire for native input elements to remain native as long as contrast was OK, as opposed to the user-script solutions that just force dark-on-light text for all inputs.

That said, there are cases such as this where things don't look so hot, so I ended up adding the 'force standard colors' option to emulate the aforementioned user script solution. It should passively set the inputs to be black foreground, white background (which may not match the site colors exactly, but the extension is in no way context-aware enough to guess the right colors), but it should look better than it does now.

[jaybosamiya]

Force-standard-colors feature still is unable to fix it. In fact, it stays the same, despite having the icon show up and it tread it as "standard".

Running an "Inspect Element" on each of the different parts, it seems that the issue happens because both the "To" and "Subject" fields are <input> tags but the "From" is a <button> and the "say something" is a <div>.

I can now understand why any kind of fix on these would not work unless it were to be made either very context aware, or had some kind of hardcoding for the website, so feel free to close this issue if you too are convinced that this can't be fixed in the extension.

[DmitriK]

Not only is from a button, but it has a color set from the site CSS (q6 class, RGB(33,33,33) in my view), so the extension fixes it. It's the lack of styling for the input fields that is the root of the problem. Looking at my code again I see that 'force standard colors' does not force input elements to standard colors; it only forces regular elements for those who are running with 'use system colors' on. Thinking about it a little bit now, I'm not sure if I actually want that to be the case, so I'm going to leave this open for now until I can decide what the correct solution will be.

[DmitriK]

I've release a new version that appears to fix the issue on my-end. Can you test if this is still a problem.

[jaybosamiya]

Partially, yes. :) Partially, no. :(

It works great if I manually click on the "Force standard colors" button, but if I add it into the options for the same, then it doesn't seem to work all that well (i.e., it shows "std" in the icon, but it still has the issue). I did try increasing delay, but still it doesn't seem to be fixed even with a longer delay.

[DmitriK]

Herp derp, my mistake, I was loading the standard gmail interface in my hurry to check which bugs the new version fixed. Now that I've pulled the right site up, I do see the issue with the list. I'll keep at it.

[jaybosamiya]

No problemo :) I love the effort you've put into this extension and I can work with manually clicking to standard until you are able to fix it. Thanks for all the work you do to make our machines look nicer :)

On Mon, Dec 18, 2017 at 11:03 PM Dmitri Kourennyi notifications@github.com wrote:

Herp derp, my mistake, I was loading the standard gmail interface in my hurry to check which bugs the new version fixed. Now that I've pulled the right site up, I do see the issue with the list. I'll keep at it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DmitriK/darkContrast/issues/27#issuecomment-352633754, or mute the thread https://github.com/notifications/unsubscribe-auth/AFa5fj0RzicgwvL3Ut4XEvkhzblu4BcZks5tBzWagaJpZM4Pc742 .

--

Sent from my iPhone

[jaybosamiya]

Hi, not sure what you updated, but it suddenly seems to work perfectly in Inbox, using the "Force standard colors" override (and I no longer need to click "Force standard colors". Thanks a lot for looking into this and fixing it :)

Feel free to close this if you think the changes made actually were supposed to affect this and have fixed it :)

[DmitriK]

Yes, I made sure this got fixed in the latest overhaul. I generally wait a few days to make sure extension updates have gone out on AMO before asking people to test bugs. It looks like I forgot to respond to this one. Thanks for confirming it works.