DmitriySalnikov / godot_debug_draw_3d

Draw 3D debug graphics and 2D overlays with this add-on.
https://dd3d.dmitriysalnikov.ru/
Other
451 stars 23 forks source link

[Feature Request]: Statically link libgcc and libstdc++ on linux #45

Closed goatchurchprime closed 3 months ago

goatchurchprime commented 4 months ago

Feature description

This library doesn't work under nixos due to the libstdc++ library not being statically linked.

There might be similar portability issues to other linux distros.

image

This was noted for the webrtc plugin: https://github.com/godotengine/webrtc-native/issues/110

Implementation Ideas

The fix was a couple of settings in the SConstruct file to force static linking to the libstdc++ libraries. https://github.com/godotengine/webrtc-native/pull/109/commits/1de32aa9ea1f3f4e1fd3f5f9b283ac4dc2befae1

DmitriySalnikov commented 4 months ago

There might be similar portability issues to other linux distros.

Sure. I have already faced another problem. My library refused to run on Ubuntu 20 if the library was built on Ubuntu 22. I found these build flags, but as far as I remember it still didn't solve the problem, so I just rolled back the Ubuntu version inside Github CI and everything worked.

You can test these changes here

😔 fkP4hntFE7

DmitriySalnikov commented 4 months ago

@goatchurchprime so is the library working now?

goatchurchprime commented 3 months ago

Confirmed that April version does not work, and this May version does work.
I think @Nitwel had sent me a fixed version that he compiled himself, it worked, and then I completely forgot about it.