Fix passive event listener calling preventDefault() with drag

DmitryBaranovskiy / raphael

JavaScript Vector Library

https://dmitrybaranovskiy.github.io/raphael/

MIT License

11.27k stars 1.67k forks source link

Fix passive event listener calling preventDefault() with drag #1113

Closed hypertexttheresa closed 4 years ago

pmmiv commented 4 years ago

From Google: "The Chromebook Plus shipped with an intervention to make all touch handlers (including non-document ones) passive by default. This was done for performance reasons on this device alone."

We've added an addition to our code similar to this pr, and it resolved the issues we were seeing as a result of the passive event listener.

pmmiv commented 4 years ago

I'm sorry if my comment was misleading - I am not a raphael contributer. I was trying to support this pr as a good change.

I'm not sure why it was closed.

hypertexttheresa commented 4 years ago

@pmmiv Ah I misunderstood then - I thought if raphael was updated in another way, then this pull request had become redundant. Now I understand you ran into similar issues and similarly patched the library. Let me reopen the pr then :).