DmitryEfimenko / TwitterBootstrapMvc

Fluent implementation of ASP.NET-MVC HTML helpers for Twitter Bootstrap.
Apache License 2.0
224 stars 79 forks source link

The ShowRequiredStar( false ) global setting ddoesn't work after the 3.10.4 update #219

Closed Jak3b0 closed 10 years ago

Jak3b0 commented 10 years ago

Hi!

I was testing the fixe you made for the issue https://github.com/DmitryEfimenko/TwitterBootstrapMvc/issues/218 and I noticed that the global settings ShowRequiredStar( false ) it not working anymore.

I call this in the _ViewStart.cshtml file...

DmitryEfimenko commented 10 years ago

I tested this. Works fine for me. What exact code do you have?

Jak3b0 commented 10 years ago

Sure!

Here is the code in my _ViewStart.cshtml file:

@{
    Layout = "~/Views/Shared/_Layout.cshtml";

    Html.Bootstrap().Globals().ShowRequiredStar( false );
}

And here is the code for my view:

@model SignInViewModel

@{
   ViewBag.Title = ApplicationResources.View_SignIn_Title;
}

@using( var form = Html.Bootstrap().Begin( new Form() ) )
{
   <div class="row">
      <div class="col-md-6 col-sm-8">
         <fieldset>
            <legend>@ApplicationResources.View_SignIn_Title.ToUpper()</legend>
            @Html.Bootstrap().ValidationSummary().ExcludePropertyErrors()
            @Html.AntiForgeryToken()

            @form.FormGroup().TextBoxFor( m => m.Email ).AutoFocus()
            @form.FormGroup().PasswordFor( m => m.Password )
            @form.FormGroup().CheckBoxFor( m => m.RememberMe )

            @form.FormGroup().CustomControls( Html.Bootstrap().SubmitButton().Text( @ApplicationResources.Action_SignIn ).Style( ButtonStyle.Info ) )
         </fieldset>
      </div>
   </div>
}

@section scripts{
   @Scripts.Render( "~/bundles/script/jqueryval" )
   @Scripts.Render( "~/bundles/script/bmvc" )
}

The result is that the "*" are shown even if I have set it to not show the "required stars" in the _ViewStart.cshtml file.

DmitryEfimenko commented 10 years ago

I just tested it with this exact code and it all works fine for me. I can't reproduce it... would you be able to send a project sample to me with the issue present?

Jak3b0 commented 10 years ago

I might be a noob on this but is there a way with GitHub to send you a private message with the zip file?

Jak3b0 commented 10 years ago

Ok.. I've put it on Google Drive.. here's the link. https://drive.google.com/file/d/0B9_yod4x69wLRTl3aTJPQTNtTTQ/edit?usp=sharing

NOTE: I removed my license file from it...

DmitryEfimenko commented 10 years ago

Thanks for doing this. I don't think there is a way of doing private messages on GitHub at all. This is fixed. Please get latest.