search

DmitryEfimenko / TwitterBootstrapMvc

Fluent implementation of ASP.NET-MVC HTML helpers for Twitter Bootstrap.
Apache License 2.0
224 stars 79 forks source link

$('.btn').button(); breaks css style #353

Open angelocarlotto opened 9 years ago

angelocarlotto commented 9 years ago

Whats uppp, dude! Me and my Friend and coworker @akamud updated our project with the latest version, BTW thanks a lot for the helpful updates, and noticed that our button broke in our layout and the cause was this line:

$('.btn').button();

At line 32 in the file TwitterBootstrapMvcJs.js

What would be the good-heartedly reason of this change?

angelocarlotto commented 9 years ago

Here are the screenshots showing the problem: This is the corect version: 2014-12-19_11-20-25

This is after the update: 2014-12-19_11-19-55

DmitryEfimenko commented 9 years ago

Hello, I'm sorry this change broke something. The change closed this bug. Basically it's needed for method @Html.Bootstrap().Button("Submit").LoadingText("Loading") to work.

It's weird that it broke styling on the page because I don't think this script adds any classes... What's useful to point out is that class btn is a Bootstrap specific class, and using it on non-Bootstrappy buttons may not be a good idea.

Let me know if I can help somehow, but I'm not sure that removing this script is the best solution.