DmitryFrolovTri / gitea-limit-repo-size

The repository to capture bugs to fix during development of limit-repo-size feature (https://github.com/go-gitea/gitea/pull/21820)
MIT License
0 stars 0 forks source link

During gitea test suite run issue with go fmt #13

Closed DmitryFrolovTri closed 1 year ago

DmitryFrolovTri commented 1 year ago

Hi following error in the gitea test suite run: https://github.com/go-gitea/gitea/actions/runs/4990209629/jobs/8942143108?pr=21820

make[1]: write error: stdout
go run github.com/google/go-licenses@v1.6.0 save . --force --save_path=.go-licenses 2>/dev/null
make[1]: [Makefile:490: assets/go-licenses.json] Error 1 (ignored)
go run build/generate-go-licenses.go .go-licenses assets/go-licenses.json
go run github.com/go-swagger/go-swagger/cmd/swagger@v0.30.4 generate spec -x "code.gitea.io/sdk" -o './templates/swagger/v1_json.tmpl'
sed -i 's|"basePath": *"/api/v1"|"basePath": "{{AppSubUrl \| JSEscape \| Safe}}/api/v1"|g' './templates/swagger/v1_json.tmpl'
sed -i -e '$a\' './templates/swagger/v1_json.tmpl'
GOFUMPT_PACKAGE=mvdan.cc/gofumpt@v0.5.0 go run build/code-batch-process.go gitea-fmt -w '{file-list}'
Please run 'make fmt' and commit the result:
make: *** [Makefile:295: fmt-check] Error 1
diff --git a/modules/setting/repository.go b/modules/setting/repository.go
index ef64f07..1733310 100644
--- a/modules/setting/repository.go
+++ b/modules/setting/repository.go
@@ -10,6 +10,7 @@ import (
    "strings"

    "code.gitea.io/gitea/modules/log"
+
    "github.com/dustin/go-humanize"
 )

diff --git a/templates/repo/settings/options.tmpl b/templates/repo/settings/options.tmpl
index 502c[56](https://github.com/go-gitea/gitea/actions/runs/4990209629/jobs/8942143108?pr=21820#step:5:57)f..a7a1f0f 100[64](https://github.com/go-gitea/gitea/actions/runs/4990209629/jobs/8942143108?pr=21820#step:5:65)4
--- a/templates/repo/settings/options.tmpl
+++ b/templates/repo/settings/options.tmpl
@@ -15,10 +15,10 @@
                <div class="inline field">
                    <label>{{.locale.Tr "repo.repo_size"}}</label>
                    <span {{if .Err_RepoSize}}class="ui text red"{{end}}>{{FileSize .Repository.Size}}
-                       {{if .ActualSizeLimit  }}
-                       {{if .EnableSizeLimit }}
+                       {{if .ActualSizeLimit}}
+                       {{if .EnableSizeLimit}}
                            /{{FileSize .ActualSizeLimit}}
-                       {{end }}
+                       {{end}}
                        {{end}}
                    </span>
                </div>
Error: Process completed with exit code 2.
DmitryFrolovTri commented 1 year ago

Fixed by the https://github.com/DmitryFrolovTri/gitea/commit/8ac833ae621b7973fa2e38f749d9b9b5595345f6 commit.