search

DmitryKey / luke

This is mavenised Luke: Lucene Toolbox Project
Apache License 2.0
1.54k stars 352 forks source link

Open index #151

Closed begemot63 closed 5 years ago

begemot63 commented 5 years ago

When I use the Luke with ES I need to open few indexes files. Each time I need to traverse full path to the index file before I can open it. Browse dialog does not remember the previous open file location. It should start searching the file from the directory where the last index file was opened. it is very annoying to traverse file directory to find the index file again and again when looking for index file.

mocobeta commented 5 years ago

Thinlet or JavaFX or Swing Luke remember previous opened index directory paths. Which version of Luke do you use?

begemot63 commented 5 years ago

Hi I just clone latest Luke and built I got this behavior

Also I found that Luke cannot read index if I add suggestion field It throws exception

Sent from my iPhone

On Dec 6, 2018, at 3:37 PM, Tomoko Uchida notifications@github.com wrote:

Thinlet or JavaFX or Swing Luke remember previous opened index directory paths. Which version of Luke do you use?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

begemot63 commented 5 years ago

I clone https://github.com/DmitryKey/luke.git from master, then built and run

mocobeta commented 5 years ago

I got this behavior

It is unclear to me, would you explain more details? Do you still have the problem you mentioned in the issue description?

Also I found that Luke cannot read index if I add suggestion field It throws exception

Please share elasticsearch version you're using and the stack traces in log file.

begemot63 commented 5 years ago

I just checked luke JavaFX branch. Version 7.5.0

  1. clone branch and install and then launch luke.sh
  2. when you click on "Browse" button, search file dialog dies not remember location of the index file open before. You need to traverse to the directory again. When I need to see several ES indexes I need to traverse to the index directory many time. Much better to start from recently open directory where last index was located.
mocobeta commented 5 years ago

JavaFX Luke remembers previous successfully opened index paths as this screen shot.

2018-12-07 10 54 06

If opening index fails, the path is not logged. Do you open the indexes successfully with the latest JavaFX Luke? You said "Also I found that Luke cannot read index if I add suggestion field It throws exception", if so the path should not be remembered because of the failure.

begemot63 commented 5 years ago

About complete suggestion issue I opened separate issue. As to the open index issue the picture you showed is not enough. Click on "Browse" button and you will find that find file browser will start search file from home directory instead of the latest directire where last index was opened.

mocobeta commented 5 years ago

Click on "Browse" button and you will find that find file browser will start search file from home directory instead of the latest directire where last index was opened.

OK, I agree with that future versions of Luke support this feature. Would you create a patch for this?

begemot63 commented 5 years ago

Do you want that I fix the issue or I apply provided patch ?

On Thu, Dec 6, 2018 at 7:13 PM Tomoko Uchida notifications@github.com wrote:

Click on "Browse" button and you will find that find file browser will start search file from home directory instead of the latest directire where last index was opened.

OK, I agree that future versions of Luke support this feature. Would you create a patch for this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DmitryKey/luke/issues/151#issuecomment-445108906, or mute the thread https://github.com/notifications/unsubscribe-auth/AS2zeQj6I_O_B8lpV9ZIpdNNPznaV4lUks5u2dzwgaJpZM4ZHPna .

mocobeta commented 5 years ago

If you'd like to contribute to this project, patches are always welcome. Or, of course you can wait that someone (I, or anyone else) provides a patch so that we can merge it for the future release.

mocobeta commented 5 years ago

This was fixed in #154.

begemot63 commented 5 years ago

I verified the fix. The issue is closed. Thanks