search

DmitryKey / luke

This is mavenised Luke: Lucene Toolbox Project
Apache License 2.0
1.54k stars 352 forks source link

Issue #175: Offered improvement to reconstruction of unstored fields … #178

Closed chris-bamford closed 4 years ago

chris-bamford commented 4 years ago

…with no position information

Replaces previous pull request attempt. No conflicts here.

chris-bamford commented 4 years ago

Hi Dmitry,

With some help from a colleague we think we have done this correctly now. I brought my local branch up to date with changes from luke-4.10.4-field-reconstruction and then added my changes and committed/pushed to my /luke-4.10.4-field-reconstruction-2 branch. Hopefully the pull request is now OK for you.

Kind regards

DmitryKey commented 4 years ago

Hi Chris,

Merged it now, thanks for your contribution! Will you be able to verify this on your data?

chris-bamford commented 4 years ago

Sorry, missed your response in the Christmas break! I will now download the mani branch and verify it.

chris-bamford commented 4 years ago

I'll let you delete the fork as I am not 100% sure what I'm doing :-) . Please feel free.

chris-bamford commented 4 years ago

Hey @DmitryKey , what are the chances of this change making it's way into later versions of Luke (after 4.10.4)?