DmitryTsepelev / graphql-ruby-persisted_queries

Persisted queries for graphql-ruby
MIT License
172 stars 20 forks source link

Instrumentation #18

Closed bmorton closed 4 years ago

bmorton commented 4 years ago

I’ve been looking at how to tie this gem into our instrumentation framework and I think it might be worth implementing something in the gem that allows an instrumenter to be configured that could accept events for things like “cache miss.” I also have considered ActiveSupport::Notifications to do this, but not sure how you feel about taking a dependency on that (or perhaps an optional dependency).

Have you thought about this? Would you accept a PR for this?

DmitryTsepelev commented 4 years ago

I like the idea of having the notification system! I hope someone would use graphql-ruby outside the Rails ecosystem and it would be nice to make this work for them. We probably could use a built-in Tracing mechanism, since we already have this dependency. What do you think of it?