search

DmitryTsepelev / store_model

Work with JSON-backed attributes as ActiveRecord-ish models
MIT License
1.04k stars 85 forks source link

Optional parent tracking #168

Closed paneq closed 4 months ago

paneq commented 5 months ago

TODO

          # TODO: Remove me!
          expect("Verify correct github workflow").to eq("This should fail too see ENV ENABLE_PARENT_ASSIGNMENT working")

Fixes #167

DmitryTsepelev commented 4 months ago

Not passing for some reason

DmitryTsepelev commented 4 months ago

I tried to configure the repo in a way that it will run CI without any approval next time you push, so feel free to debug right here 🙂

paneq commented 4 months ago

@DmitryTsepelev It's not passing because of an intentional error that I added to verify that the github actions are executing both versions (with and without tracking) and that the ENV assignment works.

I can now follow this item from TODO list in the PR: Remove TODO from code once GH workflow is approved and verified to be working correctly (failing for ENABLE_PARENT_ASSIGNMENT=false now)

  1) StoreModel::Model#parent json activerecord model parent returns parent instance
     Failure/Error: expect("Verify correct github workflow").to eq("This should fail too see ENV ENABLE_PARENT_ASSIGNMENT working")

       expected: "This should fail too see ENV ENABLE_PARENT_ASSIGNMENT working"
            got: "Verify correct github workflow"