Closed ankane closed 2 years ago
my PR contains a fix like this too, cf. https://github.com/DmitryUlyanov/Multicore-TSNE/pull/83/commits/c3f9604afec1f4b5133947cd2cce6030cdf37f82
imo the whole cmake file should be cleaned up, it's not worthwhile to keep compatibility with such an old cmake version
Hi, thanks for this library!
This PR allows Multicore-TSNE to automatically detect OpenMP from Homebrew on Mac (
brew install libomp
) and should help with #40.More info: https://cliutils.gitlab.io/modern-cmake/chapters/packages/OpenMP.html
A few notes on the changes:
CMAKE_MINIMUM_REQUIRED
must come beforePROJECT
for it to workTARGET_LINK_LIBRARIES
must come afterADD_LIBRARY
Sample output