DmitryZakharov / homeBudgetWeb

1 stars 0 forks source link

General Clean up $1 = 1 #38

Closed DmitryZakharov closed 11 years ago

DmitryZakharov commented 11 years ago

AccountController class

@Autowired private AccountValidationService aNewAccountValidation;

the field must be renamed and so the getter and setter methods

RegistrationController, UserManagementController class

@Autowired private UserValidationService aRegistrationValidation;

the same as for the previous clase

AccountManagmentService

the class must not have methods which are manipulating database disrespecting username.

public void deleteAll(){ accountRepository.deleteAll();

all methods must be executed against specific username

DmitryZakharov commented 11 years ago

It is very dangerous to have such methods as : delete all.