Closed seatrout closed 2 years ago
@seatrout : I only use the Aside-hide version, so that's the only one I tested. It does not work for me in that the text is shown as strikethrough in Preview.
Using the original version, the marker showing the call-out emoji is pushed all the way to the edge of the screen when readable line length is toggled off. For me personally that is good enough because hovering over it still shows the pop-up correctly.
I don't use readable line length toggled off, but others may, so making your suggested adjustment seems like a good idea, though, like I said, at my end it results in strikethrough.
OK. This is mystifying. It was working for me last night and now it isn't. Let me see ...
Have you got smart typography enabled? Curly quotes break css. I just fixed mine by turning them off.
I just edited the css code above — I had inadvertently swapped round the rules for readable line length on and off.
@seatrout like I said, I don't use readable line length. I don't mind if Dmitriy accepts your pull request.
@seatrout: many thanks for your contribution.
Hey guys! I would like to add to this convo, if it's still not working. I apologize @seatrout for giving you the wrong class, it seems that I may have confused it with another. The class is supposed to be:
.markdown-preview-view.is-readable-line-width .aside-show {
...
}
(the class i previously sent was .markdown-SOURCE-view (which is edit mode) while this other one is .markdown-PREVIEW-view) but upon further inspection (I am currently working on sidenotes for Primary) , this works just as well:
.is-readable-line-width .aside-show {
...
}
I hope this helps and I apologize! Let me know if this works!
Hi @ceciliamay, thanks for your input. I fully sympathize with you making a mistake in CSS, I have made many and I have made a fool of myself with it once or twice though luckily in a DM so not visible to every Tom, Dick and Harry.
That said, if I am not mistaken you show a gap between .markdown-preview-view
and .is-readable-line-width
, which @seatrout does not show, so I hope he will update his pull request.
Aaa!! Didn't catch that again 😆 It's 3am here, so please forgive me 😆 I am trying my best. It should be no gap between .markdown-preview-view
and .is-readable-line-width
- thank you for spotting it! I will update my comment 😄
Sure, but I'm cooking!
OK. These changes have been made and checked. Neither works in live preview for me, but I hardly use it.
@seatrout: that's where we differ. I use Live Preview exclusively now, which is why it did not work for me.
Having said that, if you confirm that it does work in source mode/classic Edit, then they can be added to the snippet collection.
I can confirm that it works in source mode/classic edit.
@seatrout 👍
The sidenotes.css snippet does not work if the editor line length is not constrained (Options -> Editor -> readable line length). If you're working with that toggle off for any reason (for me, it's usually to accommodate a wide table) sidenotes will not show up properly. With the help of @ceciliamay I found this problem and she suggested an elegant fix: the modified code below automatically switches the sidebox position depending on whether the line length is set to "readable" so that it works in both states.