search

Dn-Programming-Core-Management / Dn-FamiTracker

modifications and improvements for 0CC-FamiTracker (based on j0CC-FamiTracker 0.6.3)
Other
359 stars 23 forks source link

Song/Module naming inconsistency #198

Open nstbayless opened 1 year ago

nstbayless commented 1 year ago

It seems that the term "Module" has been replaced with "Song" in some instances. Compare this screenshot of 0CC (left) and Dn (right):

image

Similarly, CFamiTrackerDoc::GetModuleName is now CFamiTrackerDoc::GetSongName, and a few other fields are renamed as well.

This doesn't really make sense, as there can be multiple songs in a module, and the term song is already used elsewhere to refer to those.

nstbayless commented 1 year ago

Also, there are a couple instances in the codebase of "Song" being replaced with "Track," also inconsistently. This is surprising because in "Track" is also used to refer to Channels sometimes.

For instance, in CFamiTrackerDoc::GetSongSpeed() and CFamiTrackerDoc::GetTrackTitle(), Song and Track are used interchangeably.

Gumball2415 commented 1 year ago

pedantically, 0CC 03.15.3+ is correct, but historically, the song-name interchanging has been present all the way back since FT 0.4.6

nstbayless commented 1 year ago

Ah, I hadn't realized that 0CC had changed this versus Famitracker. Still, it might be a good idea to fix the song/module name problem. It's often a point of confusion to new users that Famitracker modules can even have multiple songs at all.