search

Dn-Programming-Core-Management / Dn-FamiTracker

modifications and improvements for 0CC-FamiTracker (based on j0CC-FamiTracker 0.6.3)
Other
383 stars 23 forks source link

Assertion fail causing crash #209

Closed freq-mod closed 10 months ago

freq-mod commented 1 year ago

ftcrash I don't exactly remember what has caused this, it was some time ago. Might try to reproduce this

Gumball2415 commented 1 year ago

Assertion fail at https://github.com/Dn-Programming-Core-Management/Dn-FamiTracker/blob/main/Source/FamiTrackerView.cpp#L1795 it seems

Are you using a release build or beta build?

freq-mod commented 1 year ago

It was a nightly build from appveyor (97cd125)

N-SPC700 commented 1 year ago

Was able to reproduce. Simply click the double arrow indicator in the main pattern index twice.

image

Gumball2415 commented 1 year ago

This assertion fail appears to happen only on debug builds

Gumball2415 commented 1 year ago

When the cursor points to the >> in the frame editor, the selected channel is -1. This causes the assertion to fail because the CFamiTrackerView::SelectChannel() function casts this value to an unsigned integer, thus 0xffffffff is greater than MAX_CHANNELS.