Dn-Programming-Core-Management / Dn-FamiTracker

modifications and improvements for 0CC-FamiTracker (based on j0CC-FamiTracker 0.6.3)
Other
359 stars 23 forks source link

[Bug] Auto Arpeggio Plays in other channels #67

Open Toonlink8101 opened 3 years ago

Toonlink8101 commented 3 years ago

When toggling the "auto arpeggiate chords" setting under the MIDI tab and holding multiple notes on the keyboard, the selected channel will arpeggiate as normal, but if other channels of the same type are available (e.i. other pulse channels), those channels will still play. This is not present in 0CC-Famitracker, where, when the same setting is toggled on, the other channels remain silent and the selected channel arpeggiates without any other channels sounding.

I hope that makes sense. Let me know if you need anything to help with debugging :)

Gumball2415 commented 3 years ago

What version of 0CC-FT are you testing on? This is also present in 0CC-FamiTracker 0.3.14.5

Toonlink8101 commented 3 years ago

I'm using the latest release, version 0.3.0.0

Gumball2415 commented 3 years ago

I mean what version of 0CC-FT you were testing, not what version of Dn-FT

Toonlink8101 commented 3 years ago

Oh, ok. Sorry. Just to give you a full picture, these are all of the latest versions of other Famitrackers I have:

Gumball2415 commented 3 years ago

after investigating for a bit, it seems that this bug is present ever since the feature has been implemented in 0CC 0.3.14.2

Toonlink8101 commented 3 years ago

That's really strange. I only now noticed that it's present in j0CC, too. I've attached my copy of 0CC which seems to work. Let me know if it works for you or not.

0CC-FamiTracker.zip

Also, sorry about before. It had been so long since I made the original post I'd forgotten all that I said.

Toonlink8101 commented 3 years ago

I checked 0CC 0.3.5.1, and it looks like the auto-arp doesn't work there, but it is broken in a different way. When playing notes, only one channel is active, but the arpeggiation doesn't occur.

I also redownloaded 0CC 0.3.5.3 to make sure something wasn't wrong with what I had downloaded before. From what I can tell, the 0.3.5.3 on Github is the one I posted earlier, which for me, has a functioning auto-arpeggio.

Gumball2415 commented 3 years ago

i don't think the 0CC version 0.3.5.1 and 0.3.5.3 exists?

Toonlink8101 commented 3 years ago

I'm sorry; that was a typo. I meant to say 0.3.15.1 and 0.3.15.3, respectively.

Did the version I post work for you at all?

Gumball2415 commented 3 years ago

hmm, apparently it was indeed fixed in 0CC 0.3.15.1

Toonlink8101 commented 3 years ago

I'm glad it's working for you! Would that help you fix it in Dn-Famitracker, or is the situation more complicated?