search

DnDBeyond / front-end-developer-challenge

Coding challenge for front-end developers
11 stars 22 forks source link

Simplified the take-home test #10

Closed drmcknight closed 4 years ago

JayCarney commented 4 years ago

The simplified version looks good, think we're getting at the bones of what we care about without all the boilerplate of building an entire site getting in the way.

JayCarney commented 4 years ago

Thoughts after having a quick look over a poor submission; I think we should call out what we're looking for, and what we're likely to look favourably upon. In a university setting this would just be letting them have a copy of the marking rubric as well, but in this case maybe just additions to the readme with things like:

Assessment expectations

Code reviewers will be directed to pay special attention to the following

(^ this is just a quick off the top of my head, more of a rough example than something ready to copy paste into the repo)

drmcknight commented 4 years ago

Thoughts after having a quick look over a poor submission; I think we should call out what we're looking for, and what we're likely to look favourably upon. In a university setting this would just be letting them have a copy of the marking rubric as well, but in this case maybe just additions to the readme with things like:

Assessment expectations

Code reviewers will be directed to pay special attention to the following

* Styles of submission match the provided mock

* All functionality defined above is present in the submission

* Code organisation and maintainability

* If a JS framework is used, are that libraries best practices followed

* Any novel, or additional features beyond the given scope

(^ this is just a quick off the top of my head, more of a rough example than something ready to copy paste into the repo)

I'll add this in a separate PR