search

DnDBeyond / front-end-developer-challenge

Coding challenge for front-end developers
11 stars 22 forks source link

Adding hosting requirements #14

Closed drmcknight closed 4 years ago

drmcknight commented 4 years ago

This would make tests easier to grade. Do you all think we should add this as a requirement?

JayCarney commented 4 years ago

I'm a little torn on this, github pages publishes sites at https://<user>.github.io/<repository>/ so code which runs perfectly fine in webpack dev server etc... can easilty break on deploy to github because of the additional /<repository>/ in the path, which isn't the end of the world to deal with, but it's potentially an hour of googling that a candidate wouldn't have had to deal with otherwise. If a submissions js/css is broken in github because they haven't given webpack a correct public path, is that a failed submission?

drmcknight commented 4 years ago

I'm a little torn on this, github pages publishes sites at https://<user>.github.io/<repository>/ so code which runs perfectly fine in webpack dev server etc... can easilty break on deploy to github because of the additional /<repository>/ in the path, which isn't the end of the world to deal with, but it's potentially an hour of googling that a candidate wouldn't have had to deal with otherwise. If a submissions js/css is broken in github because they haven't given webpack a correct public path, is that a failed submission?

Good point! I can host these apps somewhere internally upon submission. It shouldn't take up too much of my time.