search

Dniv-ra / pe

0 stars 0 forks source link

Misleading sequence diagram #12

Open Dniv-ra opened 2 years ago

Dniv-ra commented 2 years ago

Screenshot 2021-11-12 at 5.29.33 PM.png

Isn't there supposed to be a Commons in between the parser and the storage that actually creates the trip object before writeToFile() is called for writing to Storage

nus-se-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

There is no UML diagram regarding the common part of the program

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

For instance, "Expense", "Trip" classes are not presented in any UML diagram, and we have to know their relationship from the sequence diagram, which takes much more time

[original: nus-cs2113-AY2122S1/pe-interim#442] [original labels: severity.Medium type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Downgraded to Low - does not significantly hinder reader from understanding.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]