Dniv-ra / pe

0 stars 0 forks source link

Negative exchange rates are allowed #2

Open Dniv-ra opened 2 years ago

Dniv-ra commented 2 years ago

Screenshot 2021-11-12 at 4.16.43 PM.png

As in the image above, you can see an exchange rate of -1 is allowed by the system and is reflected in the amount spent as well. Maybe the system should disallow users from using values that are illogical like negatives for exchange rates

nus-pe-script commented 2 years ago

Team's Response

deliberate design decision - understand that some users may prefer seeing the amount deducted as opposed to a positive number, thus we provide flexibility.

Downgraded to Low - use cases of negative exchange rates will likely be rare.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: While the preference to have a visual of an amount detected is a legitimate option, the values are implying that the positive value is equivalent to the negative value in the brackets which causes confusion as you can have one trip where 30 USD is 37 SGD but another where it is equivalent to -37 SGD with no indication that the latter is due to a personal preference that it is an amount deducted and not an equivalence. I agree with the downgrade to low as this might be a rare case but is still a valid concern nevertheless.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]