Velero helmchart - failed to upgrade

[p1-repo-sync-bot[bot]]

Bug

Description

Describe the problem, what were you doing when you noticed the bug?

Updating Big Bang to version 2.22.0 using Helm Charts

Provide any steps possible used to reproduce the error (ideally in an isolated fashion).

Perform Big Bang update to v.2.22.0 by updating the helmrelease.yaml file

BigBang Version

What version of BigBang were you running? 2.21.1 --> 2.22.0

This can be retrieved multiple ways:

# via helm
helm ls -n bigbang

# via the deployed umbrella git tag
kubectl get gitrepository -n bigbang

When performing the Big Bang upgrade, the velero HelmRelease generates an error and fails to finish updating. The issue appears to be extraneous code in the Velero Helm chart 5.2.2-bb.1 at line 195

bigbang     velero5.2.2-bb.0     False    False   Helm upgrade failed for release velero/velero-velero with chart velero@5.2.2-bb.1: parse error at (velero/charts/gluon/templates/bb-tests/_cypressrunner.yaml:196): unexpected {{end}}

188 ---
189 {{- end }}
190 {{- end }}
191 {{- include "gluon.util.merge" (append . "gluon.tests.cypress-runner.tpl") }}
192 {{- end }}
193 {{- end }}
194 {{- end }}
195 d }}      ###<---offending entry
196 {{- end }}
197 imagePullSecrets:
198     - name: private-registry
199 {{- end }}
200 {{- end }}
201
202 {{- define "gluon.tests.cypress-runner.base" }}

[p1-repo-sync-bot[bot]]

ryan.j.garcia commented:

---

@ppryde can you paste in a sanitized copy of your overrides you are using? Are you intending to make use of our bbtests ?

[p1-repo-sync-bot[bot]]

ppryde commented:

---

Here is the values for Velero. I'm not sure what is calling the cypressrunner, but we aren't running any tests. These are values from our DSOP-Prod cluster which has the most settings. This resides in FENCES, so there isn't any way for the cluster to access the internet.

velero:
  enabled: true
  sourceType: "helmRepo"
  plugins:
    - aws
    - csi
  values:
    resources:
      server:
        requests:
          cpu: 3000m
          memory: 2048Mi
        limits:
          cpu: 3000m
          memory: 2048Mi
    podAnnotations:
      iam.amazonaws.com/role: "arn:aws-us-gov:iam::<customer>:instance-profile/<IAMRole>"
    credentials:
      useSecret: false
    configuration:
      backupStorageLocation:
      - name: default
        bucket: <vpc-customer>-velero
        provider: aws
        config:
          region: us-gov-east-1
      extraEnvVars:
        HTTPS_PROXY: "http://xxx.xxx.xxx.215:80/"
        NO_PROXY: "169.254.169.254,xxx.xxx.xxx.0/24,.fences.dso.local,localhost,127.0.0.1,xxx.xxx.0.0/12,192.168.0.0/16,kubernetes,kubernetes.default,kubernetes.default.svc,kubernetes.default.svc.cluster,kubernetes.default.svc.cluster.local,.svc,.svc.cluster,.svc.cluster.local,.<domain>.local,.<admincluster>.local,.elb.amazonaws.com,.s3.us-gov-east-1.amazonaws.com"
      volumeSnapshotLocation:
      - name: default
        provider: aws
        config:
          region: us-gov-east-1
    schedules:
      daily-cluster-snap:
        disabled: false
        schedule: "30 2 * * *"
        useOwnerReferencesInBackup: false
        template:
          csiSnapshotTimeout: 20m
          ttl: "240h"
          storageLocation: default
          excludedNamespaces:
          - gitlab
          - gitlab-runner
          - harbor
          - nexus-repository-manager 
          - flux
          - istio-operator
          - istio-system
          - keycloak
          - kiali
          - logging
          - metrics-server
          - monitoring
          - promtail
          - sonarqube
          - tempo
          - twistlock
      critical-data-snap:
        disabled: false
        schedule: "0 1/6 * * *"
        useOwnerReferencesInBackup: false
        template:
          csiSnapshotTimeout: 20m
          ttl: "240h"
          storageLocation: default
          includedNamespaces:
          - gitlab
          - gitlab-runner
          - harbor
          - nexus-repository-manager
      bigbang-snap:
        disabled: false
        schedule: "0 3/12 * * *"
        useOwnerReferencesInBackup: false
        template:
          csiSnapshotTimeout: 20m
          ttl: "240h"
          storageLocation: default
          includedNamespaces:
          - flux
          - istio-operator
          - istio-system
          - keycloak
          - kiali
          - logging
          - metrics-server
          - monitoring
          - promtail
          - sonarqube
          - tempo
          - twistlock