DoD-Platform-One / bigbang

BigBang the product
https://repo1.dso.mil/big-bang/bigbang
Apache License 2.0
163 stars 66 forks source link

Domain is not passed down to "package" package. #52

Closed p1-repo-sync-bot[bot] closed 6 months ago

p1-repo-sync-bot[bot] commented 6 months ago

Bug

Description

Describe the problem, what were you doing when you noticed the bug?

I am attempting to use the package package, and the domain variable is not passed down from the main values.yaml file we pass. This causes the VirtualService we specify in our chart to not have the correct domain set.

See the example here: https://repo1.dso.mil/dsop/radiusmethod/socketzero/receiver/-/blob/development/README.md?ref_type=heads

The workaround is to set a domain at the package level, but shouldn't be necessary I believe.

BigBang Version

2.18.0

p1-repo-sync-bot[bot] commented 6 months ago

michaelmartin commented:

I think in your bagbang values.yaml file you'd want to nest packages under the values key in order for domain to passed through to the socketzero chart. e.g:

packages:
  socketzero:
    values:
      domain: "bigbang.dev" # replace with your domain   

Can you try that out and let us know if that doesn't solve the issue?

p1-repo-sync-bot[bot] commented 6 months ago

Issue 'Domain is not passed down to "package" package.' closed from GitLab side

p1-repo-sync-bot[bot] commented 6 months ago

danny-radiusmethod commented:

This worked! Thanks.