DoD-Platform-One / monitoring

Monitoring Stack Bootstrapper (Prometheus, Grafana)
https://repo1.dso.mil/big-bang/product/packages/monitoring
Apache License 2.0
2 stars 1 forks source link

Use busybox for cleanupProxy image #11

Closed p1-repo-sync-bot[bot] closed 3 months ago

p1-repo-sync-bot[bot] commented 4 months ago

Feature Request

Why

We should be able to use an existing community image (like busybox) to perform the cleanupProxy actions.

Proposed Solution

Use the alpine container image in values.yaml:

cleanupProxy:
      image:
        registry: registry1.dso.mil
        repository: ironbank/opensource/alpinelinux/alpine
        tag: 3.19.1
        sha: ""
        pullPolicy: IfNotPresent

and update the job-patchWebhook.yaml:

- name: cleanup-proxy
  command:
  - /bin/sh
  - -c
  - |
    until wget --spider -q http://localhost:15021/healthz/ready; do echo \"Waiting for Sidecar...\"; sleep 3; done;
    echo \"Sidecar available, sleeping 10 seconds then killing istio proxy...\";
    sleep 10;
    x=$(echo $?); wget --post-data='' -qO- http://localhost:15020/quitquitquit && exit $x
p1-repo-sync-bot[bot] commented 4 months ago

staskiewicz.blane commented:

@willswire you should be able to override the cleanupProxy image to ironbank/opensource/alpinelinux/alpine if you prefer using it over the big-bang/base image. We currently have big-bang/base as our standardized utility image

p1-repo-sync-bot[bot] commented 3 months ago

jimmyungerman commented:

@willswire just checking in, were you able to override the image?

p1-repo-sync-bot[bot] commented 3 months ago

jimmyungerman commented:

@willswire I can confirm that the cleanup proxy container uses the busybox image with the following overrides:

monitoring:
  enabled: true
  values:
    prometheusOperator:
      admissionWebhooks:
        cleanupProxy:
          image:
            registry: docker.io
            repository: busybox
            tag: latest
p1-repo-sync-bot[bot] commented 3 months ago

Issue 'Use busybox for cleanupProxy image' closed from GitLab side