DoD-Platform-One / monitoring

Monitoring Stack Bootstrapper (Prometheus, Grafana)
https://repo1.dso.mil/big-bang/product/packages/monitoring
Apache License 2.0
2 stars 1 forks source link

Adds a delay before sidecar proxy is killed #2

Closed rjferguson21 closed 8 months ago

rjferguson21 commented 10 months ago

This partially addresses https://repo1.dso.mil/big-bang/product/packages/monitoring/-/issues/118

The way the job is written at the moment creates a race condition between the cleanup-proxy and the create pod.

p1-repo-sync-bot[bot] commented 10 months ago

Thank You!

Your contribution to the DSO Repo1 has been mirrored to https://repo1.dso.mil/big-bang/product/packages/monitoring/-/merge_requests/230

Current features

  1. Comments will be mirrored to the associated GitLab Merge Request.

  2. Quote Replies will mirror to Gitlab as a Thread

  3. Updates to code will be pushed to the associated GitLab Merge Request.

  4. Closing the PR will close the associated GitLab Merge Request.

    Features not available yet

  5. Comments on code will not be mirrored

p1-repo-sync-bot[bot] commented 10 months ago

Merge Request synchronized with commit https://github.com/DoD-Platform-One/monitoring/pull/2/commits/1b608dd8761b07224cf6c51577fffb0842177583

p1-repo-sync-bot[bot] commented 10 months ago

Merge Request synchronized with commit https://github.com/DoD-Platform-One/monitoring/pull/2/commits/fe752a98911c06f8d17eaad5419f1d73ab4d1115

p1-repo-sync-bot[bot] commented 10 months ago

bb8-bot commented:

@group_3988_bot_f3cc1a4c3f66ffe8398fad5cbe77e8ec This merge request is unlabelled and not marked as draft. Please add one or more labels.

To mark as draft prefix this merge request title with Draft:

If this merge request is ready for review remove Draft: and label ~status::review

MR Title Keywords

To easily adjust the pipeline behavior without a commit, keywords can be placed in the title of Merge Requests.

Supported keywords:

MR Labels

Similar to the MR title keywords described above, gitlab labels can be added to Merge Requests to adjust CI pipeline behavior.

Labels for BigBang MRs

Labels for BigBang and package MRs

p1-repo-sync-bot[bot] commented 10 months ago

Merge Request synchronized with commit https://github.com/DoD-Platform-One/monitoring/pull/2/commits/bbfc3489998e8c5976e4ef75d417e7cb4935aa4a

p1-repo-sync-bot[bot] commented 10 months ago

ryan.j.garcia commented:

@rjferguson21 Can we test moving the cleanup script portions to the main container as outlined in one of the items of the issue

p1-repo-sync-bot[bot] commented 10 months ago

Pipeline is running at https://repo1.dso.mil/big-bang/product/packages/monitoring/-/pipelines/2289087

thompsor commented 8 months ago

The related MR: https://repo1.dso.mil/big-bang/product/packages/monitoring/-/merge_requests/230 was merged. Closing the PR.