DoHoonKim8 / halo2-lasso

Benchmark for adding Lasso lookup argument to halo2 backend
MIT License
30 stars 4 forks source link

Implement Lasso inside Hyperplonk #4

Open DoHoonKim8 opened 1 year ago

DoHoonKim8 commented 1 year ago

Implement Lasso inside Hyperplonk. Can run the test

cargo test --release --package plonkish_backend --lib -- backend::lookup::lasso::test::and::test --exact --nocapture
cargo test --release --package plonkish_backend --lib -- backend::lookup::lasso::test::range::test --exact --nocapture

The remaining things to do:

DoHoonKim8 commented 1 year ago
  • My understanding is that the codebase starts from Han's plonkish repository and then implements Lasso on top of it. But the git history from the plonkish repository is not here? maybe you copied the code into this repository? I highly recommend implementing Lasso on top of Han's plonkish repository keeping all the commit history from the plonkish repository; because that will make it much easier later to merge this implementation to Han's repo, or backport changes from Han's repo into here.

Thanks for pointing out this. It's my mistake to remove all the git history. I will fix this.

For the reason I transferred the code from plonkish to halo2-lasso because Lasso implementation on top of plonkish makes huge changes to the original codebase which makes impossible to merge into Han's repo later(also merge into here from upstream). So I thought that it would be better to have separate repo only for this work.(Ofc I wrote at readme that this repo is fork of plonkish )