search

DoSomething / aurora

:crescent_moon: The DoSomething.org admin interface.
https://admin.dosomething.org
MIT License
1 stars 2 forks source link

Add Voter Registration Status field to Profile Edit Form #219

Closed mendelB closed 5 years ago

mendelB commented 5 years ago

What's this PR do?

This PR adds the voter_registration_status field to the User's profile edit form.

https://github.com/DoSomething/aurora/pull/219/commits/d52fcbd472779266312e02ae0fa07c43460510b1 Removes a hack to strip the sms_status field from the Northstar payload if null since we've made that field nullable.

How should this be reviewed?

👀

Any background context you want to provide?

This won't actually completely work until we merge https://github.com/DoSomething/northstar/pull/903 to remove some hierarchy validation for arbitrary status updates and make this field nullable within Northstar's Registerer validation to allow submitting this field when it's unset or to actively unset this field.

And @katiecrane sorry to belabor this point, but I just want to confirm that you think it's the correct call to have us send along a null value for this field instead of restraining it in Aurora so we don't unset anything in Northstar? (One new thought I had is that it might be indirect to allow what is formally a placeholder value to actually update the database?)

Relevant Tickets

Pivotal ID #165974120

katiecrane commented 5 years ago

I just want to confirm that you think it's the correct call to have us send along a null value for this field instead of restraining it in Aurora so we don't unset anything in Northstar? (One new thought I had is that it might be indirect to allow what is formally a placeholder value to actually update the database?)

I know we've talked about this a lot already but these sentences are confusing me!

mendelB commented 5 years ago

I just want to confirm that you think it's the correct call to have us send along a null value for this field instead of restraining it in Aurora so we don't unset anything in Northstar? (One new thought I had is that it might be indirect to allow what is formally a placeholder value to actually update the database?)

I know we've talked about this a lot already but these sentences are confusing me!

I started making a little more sense in Slack in this thread

We determined that we can keep this field nullable, and while doing so had the chance to update the sms_status field to nullable as well in https://github.com/DoSomething/northstar/pull/903 and remove an old hack in https://github.com/DoSomething/aurora/pull/219/commits/d52fcbd472779266312e02ae0fa07c43460510b1