This pull request tweaks the .editorconfig settings to better match the settings in Prettier.
Prettier's default setting is spaces and the width is set to 2 spaces. Our .editorconfig file settings declares an indent_space=4 for all files and then specifies indent_space=2 for some specific files.
I think it'd be best to switch the default to 2 to match Prettier and then set 4 for specific files (like PHP where PSR-2 dictates code should have 4 spaces.
How should this be reviewed?
Mostly just need to 👀 the .editorconfig changes. The rest is mostly all changes to SCSS files.
NOTE: I originally changed it so all files used 2 forgetting about the PSR-2 requirement; PHP-CS Fixer reminded me of that when it ran on CircleCI and failed! 😅
What's this PR do?
This pull request tweaks the
.editorconfigsettings to better match the settings in Prettier.Prettier's default setting is
spacesand the width is set to2 spaces. Our.editorconfigfile settings declares anindent_space=4for all files and then specifiesindent_space=2for some specific files.I think it'd be best to switch the default to
2to match Prettier and then set4for specific files (like PHP where PSR-2 dictates code should have4spaces.How should this be reviewed?
Mostly just need to 👀 the
.editorconfigchanges. The rest is mostly all changes to SCSS files.NOTE: I originally changed it so all files used
2forgetting about the PSR-2 requirement; PHP-CS Fixer reminded me of that when it ran on CircleCI and failed! 😅Relevant tickets
References Pivotal #174412695.
Checklist