DoSomething / chompy

:card_index: The DoSomething.org third-party importer.
MIT License
1 stars 0 forks source link

Cleanup fetching posts in RTV import #152

Closed aaronschachter closed 4 years ago

aaronschachter commented 4 years ago

What's this PR do?

This pull request fixes a TODO of renaming the getPost function to getPosts in our Rogue service, and uses it within a getPost function to the ImportRockTheVoteRecord job, adding tests to verify the filters passed to the GET /v3/posts request.

How should this be reviewed?

👀

Any background context you want to provide?

It'll be handy to have this new getPost function within the ImportRockTheVoteRecord job when we eventually support multiple voter registration posts, and will need to inspect the details of each post to determine whether we should create or update a post based on the Started registration column.

Relevant tickets

Prep for Pivotal #171737617.

Checklist