Closed aaronschachter closed 4 years ago
This pull request removes the convenience startedRegistration property added to a RockTheVoteRecord in #166 -- because older failed jobs in the queue don't have it set.
startedRegistration
RockTheVoteRecord
This results in the error:
Undefined property: Chompy\RockTheVoteRecord::$startedRegistration
when we retry these failed jobs.
Instead, we can use the record's getPostDetails helper to inspect the record's Started registration datetime.
getPostDetails
Started registration
👀
🌵
References Pivotal #172805635.
What's this PR do?
This pull request removes the convenience
startedRegistration
property added to aRockTheVoteRecord
in #166 -- because older failed jobs in the queue don't have it set.This results in the error:
when we retry these failed jobs.
Instead, we can use the record's
getPostDetails
helper to inspect the record'sStarted registration
datetime.How should this be reviewed?
👀
Any background context you want to provide?
🌵
Relevant tickets
References Pivotal #172805635.
Checklist