DoSomething / chompy

:card_index: The DoSomething.org third-party importer.
MIT License
1 stars 0 forks source link

Removes startedRegistration property added in #166 #168

Closed aaronschachter closed 4 years ago

aaronschachter commented 4 years ago

What's this PR do?

This pull request removes the convenience startedRegistration property added to a RockTheVoteRecord in #166 -- because older failed jobs in the queue don't have it set.

This results in the error:

 Undefined property: Chompy\RockTheVoteRecord::$startedRegistration   

when we retry these failed jobs.

Instead, we can use the record's getPostDetails helper to inspect the record's Started registration datetime.

How should this be reviewed?

👀

Any background context you want to provide?

🌵

Relevant tickets

References Pivotal #172805635.

Checklist