This pull request modifies the RTV import to include a group_id value when creating a voter-reg post if one is found within the tracking source.
Additional changes:
Renames the instances of "referral code" within the import code as "tracking source" to keep the name consistent with RTV terminology / internal docs, and hopefully make the code more readable.
Removes check for deprecated iframe within a tracking source per Slack thread
How should this be reviewed?
👀
An easy manual test is to use the test import form to create a new voter-reg post with a tracking source for a valid group ID, e.g source:web,source_details:groupTest,group_id=3.
Confirm the post is created with the expected group_id value.
Any background context you want to provide?
We're not sending along the group_id from the web yet, but this gets us ready to store it properly once we are.
What's this PR do?
This pull request modifies the RTV import to include a
group_idvalue when creating avoter-regpost if one is found within the tracking source.Additional changes:
Renames the instances of "referral code" within the import code as "tracking source" to keep the name consistent with RTV terminology / internal docs, and hopefully make the code more readable.
Removes check for deprecated
iframewithin a tracking source per Slack threadHow should this be reviewed?
👀
An easy manual test is to use the test import form to create a new voter-reg post with a tracking source for a valid group ID, e.g
source:web,source_details:groupTest,group_id=3.Confirm the post is created with the expected
group_idvalue.Any background context you want to provide?
We're not sending along the
group_idfrom the web yet, but this gets us ready to store it properly once we are.Relevant tickets
References Pivotal #173019785.
Checklist