DoSomething / chompy

:card_index: The DoSomething.org third-party importer.
MIT License
1 stars 0 forks source link

Don't send activate account email when creating user with Step 1 status #190

Closed aaronschachter closed 4 years ago

aaronschachter commented 4 years ago

What's this PR do?

This pull request modifies create user logic in the Rock The Vote import, checking to see if the status is Step 1.

If it is -- only include the RTV record collected from the user at Step 1: email and zip.

If it isn't, use all data provided within the RTV record.

How should this be reviewed?

👀

Any background context you want to provide?

We have an open question out to Rock The Vote to understand why we see values for some fields that shouldn't have been collected yet at Step 1, but for now this code change will prevent us from sending Activate Account emails to users who haven't been prompted with an email opt-in form yet.

Relevant tickets

References Pivotal #174844127.

Checklist