Updated the navigation to use dropdown

DoSomething / forge

🎨 The DoSomething.org pattern library.

http://forge.dosomething.org

MIT License

48 stars 14 forks source link

Updated the navigation to use dropdown #435

Closed itsjoekent closed 9 years ago

itsjoekent commented 9 years ago

Required for https://github.com/DoSomething/dosomething/issues/1861

Adds dropdown menu on desktop and styles the mobile options

Screenshots

screen shot 2015-02-04 at 4 07 52 pm screen shot 2015-02-04 at 4 08 18 pm

sbsmith86 commented 9 years ago

In the mobile view screenshot it looks like I can see the list bullets next to my account and logout. Is that supposed to be there?

itsjoekent commented 9 years ago

@sbsmith86 thats a good catch, never seen saw that...

DFurnes commented 9 years ago

It looks like some of the alignment could use another pass. There's also a lot of empty space to the right of the user's name for people with shorter names. Maybe @lkpttn can provide some input on ways of handling that?

0ebeccaa-ac88-11e4-98d6-83e5ebb39fe0

0ebe1990-ac88-11e4-8ebb-403844084ace

DFurnes commented 9 years ago

Also some linting errors to check out! :)

https://travis-ci.org/DoSomething/neue/builds/49514823

itsjoekent commented 9 years ago

Alright, everything except the margin stuff seems ready. I think I'm blind because I don't see where the issue is @DFurnes

itsjoekent commented 9 years ago

Great, I broke this PR.