DoSomething / forge

🎨 The DoSomething.org pattern library.

http://forge.dosomething.org

MIT License

48 stars 14 forks source link

Move SVG icons into data URLs. #461

Closed DFurnes closed 9 years ago

DFurnes commented 9 years ago

Changes

Moves remaining SVG icons (search, loading spinner) into data URLs. This means less HTTP requests and faster page-loads (at least until HTTP/2 arrives!)
Changes option icons (checkmark and radio button) from base64-encoded data URLs to UTF-8. This is easier to edit (yay!) and gzips better when packing a bunch of icons into the CSS source (extra yay!)
Adds a nice little data-url() helper function.

For review: @DoSomething/front-end

barryclark commented 9 years ago

Nice!

weerd commented 9 years ago

Pretty cool! Can you confirm these load fine in IE9/10 + Firefox?

DFurnes commented 9 years ago

:sob:

DFurnes commented 9 years ago

Alright! Fixed. :godmode:

We needed to URL-encode data URLs for these to work properly in IE9, IE10, and Firefox. Hacked together a little url-encode() function which was pretty cool though so not all is lost.

weerd commented 9 years ago

@_@ :+1: cool stuff!