DoSomething / forge

🎨 The DoSomething.org pattern library.
http://forge.dosomething.org
MIT License
48 stars 14 forks source link

Add fallback for modal overlay in IE8. #503

Closed DFurnes closed 9 years ago

DFurnes commented 9 years ago

Changes

For review: @DoSomething/front-end

DFurnes commented 9 years ago

I think my preference is to keep all of our styles in Neue, and just have dosomething-modal hold modal logic (showing, hiding, transitions, etc) with a lightweight "starter" style that's more general-purpose in the modal package.

But that's something we can think more on & decide later on.

weerd commented 9 years ago

Makes sense. It should be more specific to the project that implements the modal, that decides what the background would otherwise be and appropriate fallback :) :+1: