Closed DFurnes closed 8 years ago
Looks good!
Out of curiosity would table-layout: fixed
have helped w/ letting the max-width
property not be overridden?
I think the problem with table-layout: fixed
is that we'd need to set a specific width on one of the columns, but we want them both to expand to their maximum widths. But interesting stuff! There's so much display: table
wizardry to know. :dizzy:
Changes
References DoSomething/phoenix#5139. Slightly reworks the
.-center
modifier to fix an issue where the body doesn't fill the figure if it doesn't have enough text to fill the cell's width.I'd recommend checking out the final code for the
.-center
modifier, since the diff gets a bit muddied by indentation and shifting things around for readability. The commit comments & inline comments in the code also have more rationale for each change.Screenshots
Sad misaligned cat, taken from the 6.6.0 release:![screen shot 2015-09-17 at 11 02 27 am](https://cloud.githubusercontent.com/assets/583202/9937066/15fe7f3c-5d2d-11e5-8624-47dd4c6de31f.png)
Happy, correctly aligned cat (this branch):![screen shot 2015-09-17 at 11 01 32 am](https://cloud.githubusercontent.com/assets/583202/9937085/2ff17840-5d2d-11e5-9db9-0f521f47fa21.png)
And still lookin' good with a larger text block (this branch):![screen shot 2015-09-17 at 11 01 15 am](https://cloud.githubusercontent.com/assets/583202/9937094/36a1d8c4-5d2d-11e5-9bb6-e74b7d6bb625.png)
@DoSomething/front-end